-
Notifications
You must be signed in to change notification settings - Fork 167
chore(prof) cleanup I/O profiling code #3406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
69fccab to
83a4fe4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3406 +/- ##
==========================================
- Coverage 61.89% 61.86% -0.03%
==========================================
Files 141 141
Lines 12501 12501
Branches 1633 1633
==========================================
- Hits 7737 7734 -3
- Misses 4042 4045 +3
Partials 722 722 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ profiler ]Benchmark execution time: 2025-10-15 11:34:15 Comparing candidate commit 77a818c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics. |
83a4fe4 to
7dab3a0
Compare
Benchmarks [ tracer ]Benchmark execution time: 2025-10-15 12:25:59 Comparing candidate commit 77a818c in PR branch Found 1 performance improvements and 4 performance regressions! Performance is the same for 188 metrics, 1 unstable metrics. scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:SamplingRuleMatchingBench/benchRegexMatching2
scenario:SamplingRuleMatchingBench/benchRegexMatching3
scenario:SpanBench/benchOpenTelemetryAPI
scenario:TraceSerializationBench/benchSerializeTrace
|
5aa119a to
2fd7ae6
Compare
2fd7ae6 to
c10d6f6
Compare
Description
All this PR does is extract the global offset table manipulation code into it's own file in preparation for larger cleanup
Reviewer checklist