Skip to content

Conversation

@realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Sep 8, 2025

Description

All this PR does is extract the global offset table manipulation code into it's own file in preparation for larger cleanup

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added profiling Relates to the Continuous Profiler tracing labels Sep 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.86%. Comparing base (9298487) to head (77a818c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3406      +/-   ##
==========================================
- Coverage   61.89%   61.86%   -0.03%     
==========================================
  Files         141      141              
  Lines       12501    12501              
  Branches     1633     1633              
==========================================
- Hits         7737     7734       -3     
- Misses       4042     4045       +3     
  Partials      722      722              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9298487...77a818c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Sep 8, 2025

Benchmarks [ profiler ]

Benchmark execution time: 2025-10-15 11:34:15

Comparing candidate commit 77a818c in PR branch florian/cleanup with baseline commit 9298487 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics.

@realFlowControl realFlowControl marked this pull request as ready for review October 7, 2025 09:50
@realFlowControl realFlowControl requested a review from a team as a code owner October 7, 2025 09:50
@realFlowControl realFlowControl requested a review from a team as a code owner October 15, 2025 11:20
@pr-commenter
Copy link

pr-commenter bot commented Oct 15, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-10-15 12:25:59

Comparing candidate commit 77a818c in PR branch florian/cleanup with baseline commit 9298487 in branch master.

Found 1 performance improvements and 4 performance regressions! Performance is the same for 188 metrics, 1 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+5.526µs; +7.734µs] or [+5.529%; +7.738%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+52.451ns; +130.949ns] or [+4.416%; +11.025%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+53.355ns; +118.845ns] or [+4.457%; +9.929%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟥 mem_peak [+1.323MB; +1.352MB] or [+3.173%; +3.243%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-35.636µs; -19.164µs] or [-8.070%; -4.340%]

@realFlowControl realFlowControl merged commit b46fa15 into master Nov 12, 2025
1679 of 1746 checks passed
@realFlowControl realFlowControl deleted the florian/cleanup branch November 12, 2025 15:13
@github-actions github-actions bot added this to the 1.14.0 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants